test_resources.py 7.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249
  1. """Tests pour src.server_mcp.resources."""
  2. from __future__ import annotations
  3. from typing import Any
  4. from unittest.mock import MagicMock
  5. import httpx
  6. import pytest
  7. from mcp.client.session import ClientSession
  8. from src.server_mcp.resources_element import (
  9. _GET_RESOURCES_WHITELIST,
  10. _filter_list,
  11. _unwrap_data,
  12. )
  13. from src.services.client_rest import HTTPMethod
  14. from tests.conftest import read_resource_json
  15. def _http_error() -> httpx.HTTPStatusError:
  16. request = httpx.Request("GET", "https://api.example.com/rest/tools/resource/1")
  17. response = httpx.Response(500, request=request)
  18. return httpx.HTTPStatusError("Server Error", request=request, response=response)
  19. class TestHelpers:
  20. def test_filter_list_filters_dict_items(self) -> None:
  21. items = [
  22. {"id": 1, "alias": "a", "extra": "x"},
  23. "raw-item",
  24. ]
  25. result = _filter_list(items, _GET_RESOURCES_WHITELIST)
  26. assert result[0] == {"id": 1, "alias": "a"}
  27. assert result[1] == "raw-item"
  28. def test_unwrap_data_returns_response_when_not_wrapped(self) -> None:
  29. raw = {"id": 1, "alias": "home"}
  30. assert _unwrap_data(raw) is raw
  31. @pytest.mark.anyio
  32. class TestResourcesMcpIntegration:
  33. async def test_list_resources_exposes_static_endpoints(
  34. self,
  35. mcp_session: ClientSession,
  36. ) -> None:
  37. result = await mcp_session.list_resources()
  38. uris = {str(resource.uri) for resource in result.resources}
  39. assert uris >= {
  40. "modx://templates",
  41. "modx://categories",
  42. "modx://clientconfig/settings",
  43. "modx://clientconfig/groups",
  44. "modx://groupmgt/resourcegroups",
  45. "modx://groupmgt/usergroups",
  46. }
  47. async def test_get_resource_via_client_session(
  48. self,
  49. mcp_session: ClientSession,
  50. client_rest: MagicMock,
  51. ) -> None:
  52. client_rest.execute.return_value = {
  53. "code": "200",
  54. "data": {
  55. "id": 10000,
  56. "alias": "accueil",
  57. "pagetitle": "Accueil",
  58. "internalKey": "ignored",
  59. },
  60. }
  61. result = await read_resource_json(mcp_session, "modx://resource/10000")
  62. assert result == {"id": 10000, "alias": "accueil", "pagetitle": "Accueil"}
  63. client_rest.execute.assert_called_once_with(
  64. method=HTTPMethod.GET,
  65. endpoint="/rest/tools/resource/10000",
  66. params={"showUnpublished": 1},
  67. )
  68. async def test_get_resource_falls_back_without_query_params_on_http_error(
  69. self,
  70. mcp_session: ClientSession,
  71. client_rest: MagicMock,
  72. ) -> None:
  73. client_rest.execute.side_effect = [
  74. _http_error(),
  75. {"code": "200", "data": {"id": 10000, "alias": "accueil"}},
  76. ]
  77. result = await read_resource_json(mcp_session, "modx://resource/10000")
  78. assert result == {"id": 10000, "alias": "accueil"}
  79. assert client_rest.execute.call_count == 2
  80. async def test_get_resource_returns_raw_wrapper_when_data_is_not_dict(
  81. self,
  82. mcp_session: ClientSession,
  83. client_rest: MagicMock,
  84. ) -> None:
  85. client_rest.execute.return_value = {"code": "200", "data": "unexpected"}
  86. result = await read_resource_json(mcp_session, "modx://resource/10000")
  87. assert result == {"data": {"code": "200", "data": "unexpected"}}
  88. async def test_get_resources_filters_list_items(
  89. self,
  90. mcp_session: ClientSession,
  91. client_rest: MagicMock,
  92. ) -> None:
  93. client_rest.execute.return_value = {
  94. "code": "200",
  95. "data": [
  96. {"id": 1, "alias": "child", "pagetitle": "Child", "extra": "x"},
  97. ],
  98. }
  99. result = await read_resource_json(mcp_session, "modx://resources/10000")
  100. assert result == {"items": [{"id": 1, "alias": "child", "pagetitle": "Child"}]}
  101. client_rest.execute.assert_called_once_with(
  102. method=HTTPMethod.GET,
  103. endpoint="/rest/tools/getresources/10000",
  104. params={"depth": -1, "includeTVs": 0, "showUnpublished": 1},
  105. )
  106. async def test_get_resources_filters_items_inside_dict(
  107. self,
  108. mcp_session: ClientSession,
  109. client_rest: MagicMock,
  110. ) -> None:
  111. client_rest.execute.return_value = {
  112. "code": "200",
  113. "data": {
  114. "items": [{"id": 2, "alias": "x", "noise": "y"}],
  115. "meta": "kept",
  116. },
  117. }
  118. result = await read_resource_json(mcp_session, "modx://resources/10000")
  119. assert result["items"] == [{"id": 2, "alias": "x"}]
  120. assert result["meta"] == "kept"
  121. async def test_get_resources_filters_flat_dict_when_no_items_key(
  122. self,
  123. mcp_session: ClientSession,
  124. client_rest: MagicMock,
  125. ) -> None:
  126. client_rest.execute.return_value = {
  127. "code": "200",
  128. "data": {"id": 3, "alias": "solo", "noise": "y"},
  129. }
  130. result = await read_resource_json(mcp_session, "modx://resources/10000")
  131. assert result == {"id": 3, "alias": "solo"}
  132. async def test_get_resources_falls_back_without_query_params_on_http_error(
  133. self,
  134. mcp_session: ClientSession,
  135. client_rest: MagicMock,
  136. ) -> None:
  137. client_rest.execute.side_effect = [
  138. _http_error(),
  139. {"code": "200", "data": [{"id": 1, "alias": "child"}]},
  140. ]
  141. result = await read_resource_json(mcp_session, "modx://resources/10000")
  142. assert result == {"items": [{"id": 1, "alias": "child"}]}
  143. assert client_rest.execute.call_count == 2
  144. async def test_get_template_via_client_session(
  145. self,
  146. mcp_session: ClientSession,
  147. client_rest: MagicMock,
  148. ) -> None:
  149. client_rest.execute.return_value = {"code": "200", "data": {"id": 12, "name": "Page"}}
  150. result = await read_resource_json(mcp_session, "modx://template/12")
  151. assert result == {"id": 12, "name": "Page"}
  152. async def test_get_templates_via_client_session(
  153. self,
  154. mcp_session: ClientSession,
  155. client_rest: MagicMock,
  156. ) -> None:
  157. client_rest.execute.return_value = {"code": "200", "data": [{"id": 12}]}
  158. result = await read_resource_json(mcp_session, "modx://templates")
  159. assert result == {"items": [{"id": 12}]}
  160. async def test_get_tv_via_client_session(
  161. self,
  162. mcp_session: ClientSession,
  163. client_rest: MagicMock,
  164. ) -> None:
  165. client_rest.execute.return_value = {"code": "200", "data": {"id": 5, "name": "tv"}}
  166. result = await read_resource_json(mcp_session, "modx://tv/5")
  167. assert result == {"id": 5, "name": "tv"}
  168. async def test_get_category_via_client_session(
  169. self,
  170. mcp_session: ClientSession,
  171. client_rest: MagicMock,
  172. ) -> None:
  173. client_rest.execute.return_value = {"code": "200", "data": {"id": 7, "category": "UI"}}
  174. result = await read_resource_json(mcp_session, "modx://category/7")
  175. assert result == {"id": 7, "category": "UI"}
  176. async def test_get_categories_via_client_session(
  177. self,
  178. mcp_session: ClientSession,
  179. client_rest: MagicMock,
  180. ) -> None:
  181. client_rest.execute.return_value = {"code": "200", "data": [{"id": 1}]}
  182. result = await read_resource_json(mcp_session, "modx://categories")
  183. assert result == {"items": [{"id": 1}]}
  184. async def test_get_categories_returns_warning_when_endpoint_unavailable(
  185. self,
  186. mcp_session: ClientSession,
  187. client_rest: MagicMock,
  188. ) -> None:
  189. client_rest.execute.side_effect = _http_error()
  190. result = await read_resource_json(mcp_session, "modx://categories")
  191. assert result == {
  192. "items": [],
  193. "warning": "Endpoint /rest/tools/categories indisponible sur ce serveur.",
  194. }