test_resources.py 7.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242
  1. """Tests pour src.server_mcp.resources."""
  2. from __future__ import annotations
  3. from typing import Any
  4. from unittest.mock import MagicMock
  5. import httpx
  6. import pytest
  7. from mcp.client.session import ClientSession
  8. from src.server_mcp.resources import (
  9. _GET_RESOURCES_WHITELIST,
  10. _filter_list,
  11. _unwrap_data,
  12. )
  13. from src.services.client_rest import HTTPMethod
  14. from tests.conftest import read_resource_json
  15. def _http_error() -> httpx.HTTPStatusError:
  16. request = httpx.Request("GET", "https://api.example.com/rest/tools/resource/1")
  17. response = httpx.Response(500, request=request)
  18. return httpx.HTTPStatusError("Server Error", request=request, response=response)
  19. class TestHelpers:
  20. def test_filter_list_filters_dict_items(self) -> None:
  21. items = [
  22. {"id": 1, "alias": "a", "extra": "x"},
  23. "raw-item",
  24. ]
  25. result = _filter_list(items, _GET_RESOURCES_WHITELIST)
  26. assert result[0] == {"id": 1, "alias": "a"}
  27. assert result[1] == "raw-item"
  28. def test_unwrap_data_returns_response_when_not_wrapped(self) -> None:
  29. raw = {"id": 1, "alias": "home"}
  30. assert _unwrap_data(raw) is raw
  31. @pytest.mark.anyio
  32. class TestResourcesMcpIntegration:
  33. async def test_list_resources_exposes_static_endpoints(
  34. self,
  35. mcp_session: ClientSession,
  36. ) -> None:
  37. result = await mcp_session.list_resources()
  38. uris = {str(resource.uri) for resource in result.resources}
  39. assert uris == {"modx://templates", "modx://categories"}
  40. async def test_get_resource_via_client_session(
  41. self,
  42. mcp_session: ClientSession,
  43. client_rest: MagicMock,
  44. ) -> None:
  45. client_rest.execute.return_value = {
  46. "code": "200",
  47. "data": {
  48. "id": 10000,
  49. "alias": "accueil",
  50. "pagetitle": "Accueil",
  51. "internalKey": "ignored",
  52. },
  53. }
  54. result = await read_resource_json(mcp_session, "modx://resource/10000")
  55. assert result == {"id": 10000, "alias": "accueil", "pagetitle": "Accueil"}
  56. client_rest.execute.assert_called_once_with(
  57. method=HTTPMethod.GET,
  58. endpoint="/rest/tools/resource/10000",
  59. params={"showUnpublished": 1},
  60. )
  61. async def test_get_resource_falls_back_without_query_params_on_http_error(
  62. self,
  63. mcp_session: ClientSession,
  64. client_rest: MagicMock,
  65. ) -> None:
  66. client_rest.execute.side_effect = [
  67. _http_error(),
  68. {"code": "200", "data": {"id": 10000, "alias": "accueil"}},
  69. ]
  70. result = await read_resource_json(mcp_session, "modx://resource/10000")
  71. assert result == {"id": 10000, "alias": "accueil"}
  72. assert client_rest.execute.call_count == 2
  73. async def test_get_resource_returns_raw_wrapper_when_data_is_not_dict(
  74. self,
  75. mcp_session: ClientSession,
  76. client_rest: MagicMock,
  77. ) -> None:
  78. client_rest.execute.return_value = {"code": "200", "data": "unexpected"}
  79. result = await read_resource_json(mcp_session, "modx://resource/10000")
  80. assert result == {"data": {"code": "200", "data": "unexpected"}}
  81. async def test_get_resources_filters_list_items(
  82. self,
  83. mcp_session: ClientSession,
  84. client_rest: MagicMock,
  85. ) -> None:
  86. client_rest.execute.return_value = {
  87. "code": "200",
  88. "data": [
  89. {"id": 1, "alias": "child", "pagetitle": "Child", "extra": "x"},
  90. ],
  91. }
  92. result = await read_resource_json(mcp_session, "modx://resources/10000")
  93. assert result == {"items": [{"id": 1, "alias": "child", "pagetitle": "Child"}]}
  94. client_rest.execute.assert_called_once_with(
  95. method=HTTPMethod.GET,
  96. endpoint="/rest/tools/getresources/10000",
  97. params={"depth": -1, "includedTv": 0, "showUnpublished": 1},
  98. )
  99. async def test_get_resources_filters_items_inside_dict(
  100. self,
  101. mcp_session: ClientSession,
  102. client_rest: MagicMock,
  103. ) -> None:
  104. client_rest.execute.return_value = {
  105. "code": "200",
  106. "data": {
  107. "items": [{"id": 2, "alias": "x", "noise": "y"}],
  108. "meta": "kept",
  109. },
  110. }
  111. result = await read_resource_json(mcp_session, "modx://resources/10000")
  112. assert result["items"] == [{"id": 2, "alias": "x"}]
  113. assert result["meta"] == "kept"
  114. async def test_get_resources_filters_flat_dict_when_no_items_key(
  115. self,
  116. mcp_session: ClientSession,
  117. client_rest: MagicMock,
  118. ) -> None:
  119. client_rest.execute.return_value = {
  120. "code": "200",
  121. "data": {"id": 3, "alias": "solo", "noise": "y"},
  122. }
  123. result = await read_resource_json(mcp_session, "modx://resources/10000")
  124. assert result == {"id": 3, "alias": "solo"}
  125. async def test_get_resources_falls_back_without_query_params_on_http_error(
  126. self,
  127. mcp_session: ClientSession,
  128. client_rest: MagicMock,
  129. ) -> None:
  130. client_rest.execute.side_effect = [
  131. _http_error(),
  132. {"code": "200", "data": [{"id": 1, "alias": "child"}]},
  133. ]
  134. result = await read_resource_json(mcp_session, "modx://resources/10000")
  135. assert result == {"items": [{"id": 1, "alias": "child"}]}
  136. assert client_rest.execute.call_count == 2
  137. async def test_get_template_via_client_session(
  138. self,
  139. mcp_session: ClientSession,
  140. client_rest: MagicMock,
  141. ) -> None:
  142. client_rest.execute.return_value = {"code": "200", "data": {"id": 12, "name": "Page"}}
  143. result = await read_resource_json(mcp_session, "modx://template/12")
  144. assert result == {"id": 12, "name": "Page"}
  145. async def test_get_templates_via_client_session(
  146. self,
  147. mcp_session: ClientSession,
  148. client_rest: MagicMock,
  149. ) -> None:
  150. client_rest.execute.return_value = {"code": "200", "data": [{"id": 12}]}
  151. result = await read_resource_json(mcp_session, "modx://templates")
  152. assert result == {"items": [{"id": 12}]}
  153. async def test_get_tv_via_client_session(
  154. self,
  155. mcp_session: ClientSession,
  156. client_rest: MagicMock,
  157. ) -> None:
  158. client_rest.execute.return_value = {"code": "200", "data": {"id": 5, "name": "tv"}}
  159. result = await read_resource_json(mcp_session, "modx://tv/5")
  160. assert result == {"id": 5, "name": "tv"}
  161. async def test_get_category_via_client_session(
  162. self,
  163. mcp_session: ClientSession,
  164. client_rest: MagicMock,
  165. ) -> None:
  166. client_rest.execute.return_value = {"code": "200", "data": {"id": 7, "category": "UI"}}
  167. result = await read_resource_json(mcp_session, "modx://category/7")
  168. assert result == {"id": 7, "category": "UI"}
  169. async def test_get_categories_via_client_session(
  170. self,
  171. mcp_session: ClientSession,
  172. client_rest: MagicMock,
  173. ) -> None:
  174. client_rest.execute.return_value = {"code": "200", "data": [{"id": 1}]}
  175. result = await read_resource_json(mcp_session, "modx://categories")
  176. assert result == {"items": [{"id": 1}]}
  177. async def test_get_categories_returns_warning_when_endpoint_unavailable(
  178. self,
  179. mcp_session: ClientSession,
  180. client_rest: MagicMock,
  181. ) -> None:
  182. client_rest.execute.side_effect = _http_error()
  183. result = await read_resource_json(mcp_session, "modx://categories")
  184. assert result == {
  185. "items": [],
  186. "warning": "Endpoint /rest/tools/categories indisponible sur ce serveur.",
  187. }