|
|
@@ -0,0 +1,242 @@
|
|
|
+"""Tests pour src.server_mcp.resources."""
|
|
|
+
|
|
|
+from __future__ import annotations
|
|
|
+
|
|
|
+from typing import Any
|
|
|
+from unittest.mock import MagicMock
|
|
|
+
|
|
|
+import httpx
|
|
|
+import pytest
|
|
|
+from mcp.client.session import ClientSession
|
|
|
+
|
|
|
+
|
|
|
+from src.server_mcp.resources import (
|
|
|
+ _GET_RESOURCES_WHITELIST,
|
|
|
+ _filter_list,
|
|
|
+ _unwrap_data,
|
|
|
+)
|
|
|
+from src.services.client_rest import HTTPMethod
|
|
|
+from tests.conftest import read_resource_json
|
|
|
+
|
|
|
+
|
|
|
+def _http_error() -> httpx.HTTPStatusError:
|
|
|
+ request = httpx.Request("GET", "https://api.example.com/rest/tools/resource/1")
|
|
|
+ response = httpx.Response(500, request=request)
|
|
|
+ return httpx.HTTPStatusError("Server Error", request=request, response=response)
|
|
|
+
|
|
|
+
|
|
|
+class TestHelpers:
|
|
|
+ def test_filter_list_filters_dict_items(self) -> None:
|
|
|
+ items = [
|
|
|
+ {"id": 1, "alias": "a", "extra": "x"},
|
|
|
+ "raw-item",
|
|
|
+ ]
|
|
|
+
|
|
|
+ result = _filter_list(items, _GET_RESOURCES_WHITELIST)
|
|
|
+
|
|
|
+ assert result[0] == {"id": 1, "alias": "a"}
|
|
|
+ assert result[1] == "raw-item"
|
|
|
+
|
|
|
+ def test_unwrap_data_returns_response_when_not_wrapped(self) -> None:
|
|
|
+ raw = {"id": 1, "alias": "home"}
|
|
|
+
|
|
|
+ assert _unwrap_data(raw) is raw
|
|
|
+
|
|
|
+
|
|
|
+@pytest.mark.anyio
|
|
|
+class TestResourcesMcpIntegration:
|
|
|
+ async def test_list_resources_exposes_static_endpoints(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ ) -> None:
|
|
|
+ result = await mcp_session.list_resources()
|
|
|
+
|
|
|
+ uris = {str(resource.uri) for resource in result.resources}
|
|
|
+ assert uris == {"modx://templates", "modx://categories"}
|
|
|
+
|
|
|
+ async def test_get_resource_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {
|
|
|
+ "code": "200",
|
|
|
+ "data": {
|
|
|
+ "id": 10000,
|
|
|
+ "alias": "accueil",
|
|
|
+ "pagetitle": "Accueil",
|
|
|
+ "internalKey": "ignored",
|
|
|
+ },
|
|
|
+ }
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resource/10000")
|
|
|
+
|
|
|
+ assert result == {"id": 10000, "alias": "accueil", "pagetitle": "Accueil"}
|
|
|
+ client_rest.execute.assert_called_once_with(
|
|
|
+ method=HTTPMethod.GET,
|
|
|
+ endpoint="/rest/tools/resource/10000",
|
|
|
+ params={"showUnpublished": 1},
|
|
|
+ )
|
|
|
+
|
|
|
+ async def test_get_resource_falls_back_without_query_params_on_http_error(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.side_effect = [
|
|
|
+ _http_error(),
|
|
|
+ {"code": "200", "data": {"id": 10000, "alias": "accueil"}},
|
|
|
+ ]
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resource/10000")
|
|
|
+
|
|
|
+ assert result == {"id": 10000, "alias": "accueil"}
|
|
|
+ assert client_rest.execute.call_count == 2
|
|
|
+
|
|
|
+ async def test_get_resource_returns_raw_wrapper_when_data_is_not_dict(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": "unexpected"}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resource/10000")
|
|
|
+
|
|
|
+ assert result == {"data": {"code": "200", "data": "unexpected"}}
|
|
|
+
|
|
|
+ async def test_get_resources_filters_list_items(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {
|
|
|
+ "code": "200",
|
|
|
+ "data": [
|
|
|
+ {"id": 1, "alias": "child", "pagetitle": "Child", "extra": "x"},
|
|
|
+ ],
|
|
|
+ }
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resources/10000")
|
|
|
+
|
|
|
+ assert result == {"items": [{"id": 1, "alias": "child", "pagetitle": "Child"}]}
|
|
|
+ client_rest.execute.assert_called_once_with(
|
|
|
+ method=HTTPMethod.GET,
|
|
|
+ endpoint="/rest/tools/getresources/10000",
|
|
|
+ params={"depth": -1, "includedTv": 0, "showUnpublished": 1},
|
|
|
+ )
|
|
|
+
|
|
|
+ async def test_get_resources_filters_items_inside_dict(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {
|
|
|
+ "code": "200",
|
|
|
+ "data": {
|
|
|
+ "items": [{"id": 2, "alias": "x", "noise": "y"}],
|
|
|
+ "meta": "kept",
|
|
|
+ },
|
|
|
+ }
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resources/10000")
|
|
|
+
|
|
|
+ assert result["items"] == [{"id": 2, "alias": "x"}]
|
|
|
+ assert result["meta"] == "kept"
|
|
|
+
|
|
|
+ async def test_get_resources_filters_flat_dict_when_no_items_key(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {
|
|
|
+ "code": "200",
|
|
|
+ "data": {"id": 3, "alias": "solo", "noise": "y"},
|
|
|
+ }
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resources/10000")
|
|
|
+
|
|
|
+ assert result == {"id": 3, "alias": "solo"}
|
|
|
+
|
|
|
+ async def test_get_resources_falls_back_without_query_params_on_http_error(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.side_effect = [
|
|
|
+ _http_error(),
|
|
|
+ {"code": "200", "data": [{"id": 1, "alias": "child"}]},
|
|
|
+ ]
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://resources/10000")
|
|
|
+
|
|
|
+ assert result == {"items": [{"id": 1, "alias": "child"}]}
|
|
|
+ assert client_rest.execute.call_count == 2
|
|
|
+
|
|
|
+ async def test_get_template_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": {"id": 12, "name": "Page"}}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://template/12")
|
|
|
+
|
|
|
+ assert result == {"id": 12, "name": "Page"}
|
|
|
+
|
|
|
+ async def test_get_templates_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": [{"id": 12}]}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://templates")
|
|
|
+
|
|
|
+ assert result == {"items": [{"id": 12}]}
|
|
|
+
|
|
|
+ async def test_get_tv_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": {"id": 5, "name": "tv"}}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://tv/5")
|
|
|
+
|
|
|
+ assert result == {"id": 5, "name": "tv"}
|
|
|
+
|
|
|
+ async def test_get_category_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": {"id": 7, "category": "UI"}}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://category/7")
|
|
|
+
|
|
|
+ assert result == {"id": 7, "category": "UI"}
|
|
|
+
|
|
|
+ async def test_get_categories_via_client_session(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.return_value = {"code": "200", "data": [{"id": 1}]}
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://categories")
|
|
|
+
|
|
|
+ assert result == {"items": [{"id": 1}]}
|
|
|
+
|
|
|
+ async def test_get_categories_returns_warning_when_endpoint_unavailable(
|
|
|
+ self,
|
|
|
+ mcp_session: ClientSession,
|
|
|
+ client_rest: MagicMock,
|
|
|
+ ) -> None:
|
|
|
+ client_rest.execute.side_effect = _http_error()
|
|
|
+
|
|
|
+ result = await read_resource_json(mcp_session, "modx://categories")
|
|
|
+
|
|
|
+ assert result == {
|
|
|
+ "items": [],
|
|
|
+ "warning": "Endpoint /rest/tools/categories indisponible sur ce serveur.",
|
|
|
+ }
|